Fix getByTestId nested custom text edge case #516
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #515
getChildrenAsText
function ingetByAPI.js
getByApi.test.js
,queryByApi.test.js
test cases about nested<Text>
component#489 fixed case like the following.
But not
This is because
filterNodeByType(child, ...)
is returned asfalse
for custom text component.So I handling the edge case for the above.
I can't sure this is the correct way, but this feature doesn't break before test cases.
Also, I refactored type checking code whether
child
isstring
ornumber
for adding totextContent
.